[Openmp-commits] [llvm] [openmp] [OFFLOAD][OPENMP] 6.0 compatible interop interface (PR #143491)

[Alex Duran via Openmp-commits]

================
@@ -80,15 +80,18 @@ typedef enum omp_interop_rc {
   omp_irc_other = -6
 } omp_interop_rc_t;
 
-typedef enum omp_interop_fr {
-  omp_ifr_cuda = 1,
-  omp_ifr_cuda_driver = 2,
-  omp_ifr_opencl = 3,
-  omp_ifr_sycl = 4,
-  omp_ifr_hip = 5,
-  omp_ifr_level_zero = 6,
-  omp_ifr_last = 7
-} omp_interop_fr_t;
----------------
adurang wrote:

There is no omp_ifr_rt. This omp.h is not the omp.h defined by the spec (maybe it should be called omp-defs.h).

 I don't think these should be labeled interop as it's not an exclusive thing to interop to be able to describe the backends if need to be (from an OpenMP program interop is the only way to talk about them, but not in the implementation). 

Maybe a less confusing alternative would be to drop the omp_ prefix and use someother one (e.g., tgt_). Would that be ok with you?

https://github.com/llvm/llvm-project/pull/143491