[Openmp-commits] [openmp] [OpenMP][runtime] Fix comparison of integer expressions of different signedness (PR #128204)
via Openmp-commits
openmp-commits at lists.llvm.org
Fri Feb 21 09:13:40 PST 2025
https://github.com/foxtran created https://github.com/llvm/llvm-project/pull/128204
This PR fixes warning which occurs if one compiles OpenMP runtime with GCC:
```
warning: comparison of integer expressions of different signedness: 'kmp_intptr_t' {aka 'long int'} and 'long unsigned int' [-Wsign-compare]
```
>From 41d314fe8afa35a951dada092f9585c8245d8521 Mon Sep 17 00:00:00 2001
From: "Igor S. Gerasimov" <i.s.ger at ya.ru>
Date: Fri, 21 Feb 2025 18:10:15 +0100
Subject: [PATCH] Fix comparison of integer expressions of different signedness
---
openmp/runtime/src/kmp_taskdeps.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/openmp/runtime/src/kmp_taskdeps.cpp b/openmp/runtime/src/kmp_taskdeps.cpp
index 392c8a2b19333..41173e9e1de6e 100644
--- a/openmp/runtime/src/kmp_taskdeps.cpp
+++ b/openmp/runtime/src/kmp_taskdeps.cpp
@@ -764,7 +764,7 @@ kmp_int32 __kmpc_omp_task_with_deps(ident_t *loc_ref, kmp_int32 gtid,
for (i = 0; i < ndeps; i++) {
ompt_deps[i].variable.ptr = (void *)dep_list[i].base_addr;
- if (dep_list[i].base_addr == KMP_SIZE_T_MAX)
+ if (dep_list[i].base_addr == (kmp_intptr_t)KMP_SIZE_T_MAX)
ompt_deps[i].dependence_type = ompt_dependence_type_out_all_memory;
else if (dep_list[i].flags.in && dep_list[i].flags.out)
ompt_deps[i].dependence_type = ompt_dependence_type_inout;
@@ -781,7 +781,7 @@ kmp_int32 __kmpc_omp_task_with_deps(ident_t *loc_ref, kmp_int32 gtid,
}
for (i = 0; i < ndeps_noalias; i++) {
ompt_deps[ndeps + i].variable.ptr = (void *)noalias_dep_list[i].base_addr;
- if (noalias_dep_list[i].base_addr == KMP_SIZE_T_MAX)
+ if (noalias_dep_list[i].base_addr == (kmp_intptr_t)KMP_SIZE_T_MAX)
ompt_deps[ndeps + i].dependence_type =
ompt_dependence_type_out_all_memory;
else if (noalias_dep_list[i].flags.in && noalias_dep_list[i].flags.out)
More information about the Openmp-commits
mailing list