[Openmp-commits] [openmp] [OpenMP] Fix libarcher tests on Ubuntu 22.04 (PR #170671)

[via Openmp-commits]

================
@@ -65,6 +71,11 @@ for feature in config.test_compiler_features:
 append_dynamic_library_path(config.omp_library_dir)
 append_dynamic_library_path(config.libarcher_obj_root+"/..")
 
+# Add LLVM bin dir to PATH.
+# llvm-symbolizer is needed to correctly resolve addresses, without relying on
+# system's addr2line.
+append_path(os.path.dirname(config.test_c_compiler))
----------------
jprotze wrote:

I see at least two issues with this approach:
- In all of my local build directories this path resolves to `/usr/bin` or `/usr/lib/ccache`.
- Although the function says `append_path`, the function actually prepends the path, so that binaries from this path will be preferred over binaries in other paths listed in the PATH variable. For the library path we certainly want the prepend behavior, for the PATH variable I would prefer appending

https://github.com/llvm/llvm-project/pull/170671