[Openmp-commits] [openmp] [OpenMP] Add libomp unit test infrastructure (PR #168063)

[Michael Kruse via Openmp-commits]

================
@@ -200,6 +211,31 @@ if(${LIBOMP_USE_HWLOC})
   )
 endif()
 
+# Build a testing version of libomp that exports all symbols for unit tests.
+# This library uses the same compiled objects as libomp, but with all symbols
+# exported to allow testing internal functions.
+if(NOT WIN32 AND NOT STUBS_LIBRARY)
+  set(LIBOMP_TEST_LDFLAGS ${LIBOMP_CONFIGURED_LDFLAGS})
+  # Replace the libomp exports with the test exports exporting all symbols.
+  if(LIBOMP_HAVE_VERSION_SCRIPT_FLAG)
+    string(REPLACE "${LIBOMP_SRC_DIR}/exports_so.txt"
+                   "${LIBOMP_SRC_DIR}/exports_test_so.txt"
+                   LIBOMP_TEST_LDFLAGS "${LIBOMP_TEST_LDFLAGS}")
----------------
Meinersbur wrote:

The modified `libomp_get_libflags` would not even add --version-script when collecting `LIBOMP_TEST_LIBFLAGS` for `omp_testing`

IMHO string replacement of command line options is a hacky thing to do, better to generate the right options in the first place.

https://github.com/llvm/llvm-project/pull/168063