[Openmp-commits] [llvm] [openmp] [offload][ompt] Added lookup function for device callbacks (PR #110007)
Jan André Reuter via Openmp-commits
openmp-commits at lists.llvm.org
Thu Sep 26 04:53:01 PDT 2024
Thyre wrote:
Aside from my comments, this looks mostly fine. It basically resembles what we were seeing with oneAPI until they removed the lookup stuff in 2024.1.0. However, this approach correctly returns that trying to register anything device tracing related will not work.
I'm not sure if it makes sense to implement the lookup functions like `ompt_get_device_time` if they return not-implemented values, but it's a starting point. I would rather not implement them and return `NULL` if a tool tries to get the function pointer.
https://github.com/llvm/llvm-project/pull/110007
More information about the Openmp-commits
mailing list