[Openmp-commits] [llvm] [openmp] [offload] Standalone build fixes (PR #118173)

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Sat Nov 30 08:10:33 PST 2024


=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>,
=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>,
=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>,
=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>,
=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>,
=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>,
=?utf-8?q?Michał_Górny?= <mgorny at gentoo.org>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/118173 at github.com>


================
@@ -1,13 +1,16 @@
 # NOTE: Don't try to build `PluginInterface` using `add_llvm_library` because we
 # don't want to export `PluginInterface` while `add_llvm_library` requires that.
-add_library(PluginCommon OBJECT
+add_library(PluginCommon STATIC
----------------
jhuber6 wrote:

I don't think the LLVM profile data thing should go here at least. Maybe @EthanLuisMcDonough knows if it was necessary to put it there. All of the LLVM libs should be handled in `add_target_library`, however we do need the dependency on intrinsics because we depend on it.

This is intentionally supposed to create a single object library that's then used to create the static libraries, we could maybe do it with static but I don't see the point when this isn't where any LLVM logic should go anyway.

https://github.com/llvm/llvm-project/pull/118173


More information about the Openmp-commits mailing list