[Openmp-commits] [openmp] [OpenMP] Ignore the error introduced by -Wvla-cxx-extension on ompt-general.cpp. (PR #114583)

[Daniel Chen via Openmp-commits]

DanielCChen wrote:

> No, this is wrong. I previous added a VLA-equal template thing in `libomp` and replaced all uses there. Can you move it somewhere common such that ompt can also use it?

Thanks for the pointer! @shiltian 
I am pretty sure this is the change you are referring to (https://github.com/llvm/llvm-project/commit/eaab947a8aa39002e8bdaa82be08cbc31e116a11).

I replaced the offending code in `ompt-general.cpp` as
```
//  int tmp_ids[ids_size];
  SimpleVLA<int> tmp_ids(ids_size);
```
and it fixed the issue. 

Since `kmp_utils.h` only has `SimpleVLA`,  I can either just include it in `ompt-general.cpp`, or rename it to something like `omp_utility.h` to be more general. Thoughts?

https://github.com/llvm/llvm-project/pull/114583