[Openmp-commits] [openmp] [OpenMP] Add num_threads clause list format and strict modifier support (PR #85466)

[Martin Storsjö via Openmp-commits]

mstorsjo wrote:

> > This change causes failed tests on i386: https://github.com/mstorsjo/llvm-mingw/actions/runs/9654575386/job/26643787120
> > ```
> > # .---command stderr------------
> > # | OMP: Error #137: Cannot create thread.
> > # | OMP: System error #8: (No system error message available)
> > # `-----------------------------
> > # error: command failed with exit status: 3
> > ```
> > 
> > 
> >     
> >       
> >     
> > 
> >       
> >     
> > 
> >     
> >   
> > I presume the test spawns a very large number of threads? Can it be marked with `UNSUPPORTED` for 32 bit environments somehow?
> 
> Yes, in the second to last case, the test uses a pretty deep level of nesting, and tests the num_threads clause list at two different nesting levels, so it will generate a lot of threads. We could modify the test so that the list used at the outer level is something like 3,1 and inner level is 3,1, which should create 9 threads at most. That should be adequate to show the feature is working correctly. Would that work for this system?

I'm pretty sure that 9 threads should be quite doable to spawn. If you put up a PR to do this modification, I might be able to test it.

https://github.com/llvm/llvm-project/pull/85466