[Openmp-commits] [libcxx] [openmp] [libc++] basic_ios<wchar_t> cannot store fill character WCHAR_MAX (PR #89305)

David Tenty via Openmp-commits openmp-commits at lists.llvm.org
Fri Jun 14 07:50:00 PDT 2024


================
@@ -590,7 +615,13 @@ protected:
 
 private:
   basic_ostream<char_type, traits_type>* __tie_;
-  mutable int_type __fill_;
+
+#if defined(_LIBCXX_IOS_USE_FILL_HELPER)
+  using _FillType = _FillHelper<_Traits>;
+#else
+  using _FillType = _SentinelValueFill<_Traits>;
+#endif
+  mutable _FillType __fill_;
----------------
daltenty wrote:

minor nit: I'd suggest `traits_type` instead of `_Traits` as the parameter here for consistency which the style of the rest of the class definition:
```suggestion
#if defined(_LIBCXX_IOS_USE_FILL_HELPER)
  using _FillType = _FillHelper<traits_type>;
#else
  using _FillType = _SentinelValueFill<traits_type>;
#endif
  mutable _FillType __fill_;
```

https://github.com/llvm/llvm-project/pull/89305


More information about the Openmp-commits mailing list