[Openmp-commits] [openmp] [OpenMP][test]Flip bit-fields in 'struct flags' for big-endian in test cases (PR #79895)
Xing Xue via Openmp-commits
openmp-commits at lists.llvm.org
Tue Jan 30 07:56:38 PST 2024
xingxue-ibm wrote:
> The change looks good to me.
>
> One thing though: grepping for `'struct kmp_depend_info'` shows two other places where we have these bit fields: `openmp/libomptarget/include/OpenMP/InternalTypes.h` and `openmp/runtime/test/tasking/hidden_helper_task/common.h`. Would it make sense to make this change there as well?
Thanks for checking, @iii-i! Changed `openmp/runtime/test/tasking/hidden_helper_task/common.h` for big-endian as well. `openmp/libomptarget/include/OpenMP/InternalTypes.h` seems to be a header for the target runtime. Since I won't be able to test changes, I'd refrain from touching it and will leave it for future if the target runtime needs to support big-endian.
https://github.com/llvm/llvm-project/pull/79895
More information about the Openmp-commits
mailing list