[Openmp-commits] [openmp] [OpenMP] Enable automatic unified shared memory on MI300A. (PR #77512)

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Tue Jan 9 19:15:19 PST 2024


================
@@ -1848,6 +1848,7 @@ struct AMDGPUDeviceTy : public GenericDeviceTy, AMDGenericDeviceTy {
         OMPX_StreamBusyWait("LIBOMPTARGET_AMDGPU_STREAM_BUSYWAIT", 2000000),
         OMPX_UseMultipleSdmaEngines(
             "LIBOMPTARGET_AMDGPU_USE_MULTIPLE_SDMA_ENGINES", false),
+        HSAXnackEnv("HSA_XNACK", false), OMPX_ApuMaps("OMPX_APU_MAPS", false),
----------------
jhuber6 wrote:

I really don't think we should be parsing HSA's environment variables redundantly. This information is available from the system target in the form of `amdgcn-amd-amdhsa-gfx...:xnack+` right? We should use that instead.

https://github.com/llvm/llvm-project/pull/77512


More information about the Openmp-commits mailing list