[Openmp-commits] [openmp] [Libomptarget] Remove extra cache for offloading entries (PR #77012)

[Johannes Doerfert via Openmp-commits]

================
@@ -159,7 +159,7 @@ struct DeviceTy {
   /// }
 
   /// Register \p Entry as an offload entry that is avalable on this device.
-  void addOffloadEntry(OffloadEntryTy &Entry);
+  void addOffloadEntry(OffloadEntryTy Entry);
----------------
jdoerfert wrote:

But it is live and unmodified during the call. I don't see why the copy helps. const ref seems better, especially since we should not store the reference as the entry could be invalid. A copy hides this, I'd say.

https://github.com/llvm/llvm-project/pull/77012