[Openmp-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [llvm] [openmp] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)

via Openmp-commits openmp-commits at lists.llvm.org
Sun Aug 11 22:44:21 PDT 2024


h-vetinari wrote:

I'm trying another approach here (now that #96171 showed we cannot get rid of `llvm_check_compiler_linker_flag` anyway) -- instead of doing the manual work-arounds for the linker flags & static targets everywhere, teach the existing function to do it (optionally).

There's  not so many callers in the code base that this looks infeasible per se, but people might want to design the API differently (e.g. have a dedicated helper function for the case under consideration here). I'm also expecting this to break in various ways until I've figured out the right invocations everywhere. There's also several implementations of `{target_,}add_flag_if_supported`, which _might_ have to expose similar arguments. Or we unify all those functions as well. Happy to iterate, or have someone else take over - I'll be the first to admit that CMake is not my forte 😅 

https://github.com/llvm/llvm-project/pull/93429


More information about the Openmp-commits mailing list