[Openmp-commits] [PATCH] D149368: [MLIR][OpenMP] Initial Lowering of Declare Target for Data

[Andrew Gozillon via Phabricator via Openmp-commits]

agozillon added inline comments.


================
Comment at: flang/lib/Optimizer/Transforms/OMPEarlyOutlining.cpp:137
+          isAddressOfGlobalDeclareTarget(value))
+        inputs.remove(value);
 
----------------
vzakhari wrote:
> FWIW, doesn't this invalidate the underlying iterator?
it might actually, thank you for the catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149368/new/

https://reviews.llvm.org/D149368