[Openmp-commits] [openmp] [OpenMP][OMPT] Fix device identifier collision during callbacks (PR #65595)

Michael Halkenhäuser via Openmp-commits openmp-commits at lists.llvm.org
Fri Sep 8 07:31:36 PDT 2023


================
@@ -1010,6 +1018,10 @@ struct GenericPluginTy {
   /// Number of devices available for the plugin.
   int32_t NumDevices = 0;
 
+  /// Offset which when added to a DeviceId will yield a unique, user-observable
+  /// device identifier.
----------------
mhalk wrote:

Since we are in the `GenericPluginTy` namespace, I'll drop the Plugin prefix and suggest: `DeviceIdStartIndex` and also go with a more verbose description -- so it should be more clear when this is actually useful.

https://github.com/llvm/llvm-project/pull/65595


More information about the Openmp-commits mailing list