[Openmp-commits] [openmp] [OpenMP][OMPT] Fix device identifier collision during callbacks (PR #65595)
Michael Halkenhäuser via Openmp-commits
openmp-commits at lists.llvm.org
Thu Sep 7 04:58:36 PDT 2023
================
@@ -1010,6 +1018,10 @@ struct GenericPluginTy {
/// Number of devices available for the plugin.
int32_t NumDevices = 0;
+ /// Offset which when added to a DeviceId will yield a unique, user-observable
+ /// device identifier.
----------------
mhalk wrote:
Valid point, I'm not pushing that naming or description.
Could also be name the corresponding variable PluginDeviceStartIndex (or similar); "global" was my go-to as a globally / unique DeviceId we wanted to determine.
Or was your initial thought that a clarification in the comment would suffice?
https://github.com/llvm/llvm-project/pull/65595
More information about the Openmp-commits
mailing list