[Openmp-commits] [mlir] [openmp] [flang] [Flang][OpenMP] Initial mapping of Fortran pointers and allocatables for target devices (PR #71766)

[Razvan Lupusoru via Openmp-commits]

================
@@ -1266,4 +1266,7 @@ void FIROpsDialect::registerTypes() {
       OpenMPPointerLikeModel<fir::LLVMPointerType>>(*getContext());
   fir::LLVMPointerType::attachInterface<
       OpenACCPointerLikeModel<fir::LLVMPointerType>>(*getContext());
+
+  fir::BoxType::attachInterface<OpenMPPointerLikeModel<fir::BoxType>>(
----------------
razvanlupusoru wrote:

This doesn't seem right. A box type is an abstract concept that is not "pointer-like" at all. This maybe is a bit more obvious at the LLVM IR level - LLVMTypeConverter::convertBoxTypeAsStruct converts it to a struct not a pointer.

https://github.com/llvm/llvm-project/pull/71766