[Openmp-commits] [flang] [openmp] [mlir] [Flang][OpenMP] Remove use of non reference values from MapInfoOp (PR #72444)

Akash Banerjee via Openmp-commits openmp-commits at lists.llvm.org
Wed Nov 22 05:27:04 PST 2023

TIFitis wrote:

> If you use side effect interface to check that you are not cloning anything with side effects, it is OK with me. I think your current patch is still cloning things it should not (like calls, but you should not have a "reject list", you should either use MLIR side effect interface or have an "op-in" list for things you know you want to clone because this is the common case you want to optimize: e.g: constant and shape.... Using the MLIR side effect interface is likely the cleanest).

Thanks for this suggestion. I have updated the code to only clone ops if they are `mlir::isMemoryEffectFree`, else their value is stored into a new temporary to be loaded and used inside the region.


More information about the Openmp-commits mailing list