[Openmp-commits] [mlir] [flang] [openmp] [Flang][OpenMP] Remove use of non reference values from MapInfoOp (PR #72444)

[via Openmp-commits]

https://github.com/jeanPerier commented:

I think you should not special case the load case but rather stay away from any cloning unless maybe when you detect a constant. Load op is not the only operation with side effects that may be emitted. Specification expressions may for instance contain pure calls (in the Fortran sense, which means they can still observe global states that could change).

So I would advise just making a temp from the bounds value instead of doing non trivial cloning (you can maybe just special case constants with fir::getIntIfConstant helper without doing any cloning with the cloning infrastructure).

https://github.com/llvm/llvm-project/pull/72444