[Openmp-commits] [openmp] [llvm] [mlir] [OpenMP][OMPIRBuilder] Handle replace uses of ConstantExpr's inside of Target regions (PR #71891)

Sergio Afonso via Openmp-commits openmp-commits at lists.llvm.org
Fri Nov 10 04:47:49 PST 2023


================
@@ -4817,11 +4817,39 @@ static Function *createOutlinedFunction(
     Builder.restoreIP(
         ArgAccessorFuncCB(Arg, Input, InputCopy, AllocaIP, Builder.saveIP()));
 
-    // Collect all the instructions
+    // Things like GEP's can come in the form of Constants, constants and
----------------
skatrak wrote:

I think it reads a little better this way, but maybe it's not what you're trying to say. Please ignore this suggestion if you don't agree with it.
```suggestion
    // Things like GEP's can come in the form of Constants. Constants and
```

https://github.com/llvm/llvm-project/pull/71891


More information about the Openmp-commits mailing list