[Openmp-commits] [openmp] [OpenMP ]Added more libomptarget reduction tests (PR #71616)

[Anton Rydahl via Openmp-commits]

https://github.com/AntonRydahl created https://github.com/llvm/llvm-project/pull/71616

Based on https://github.com/llvm/llvm-project/pull/70766 I think it would be good to have a few more offloading reduction tests, so we do not accidentally break minimum and maximum reductions another time.

>From 7d19104ceb4d42d5d7ebe0758972e1763bea243e Mon Sep 17 00:00:00 2001
From: AntonRydahl <rydahl2610 at gmail.com>
Date: Tue, 7 Nov 2023 16:54:53 -0800
Subject: [PATCH] Added more libomptarget reduction tests

---
 .../parallel_target_teams_reduction_max.cpp   | 49 +++++++++++++++++++
 .../parallel_target_teams_reduction_min.cpp   | 49 +++++++++++++++++++
 2 files changed, 98 insertions(+)
 create mode 100644 openmp/libomptarget/test/offloading/parallel_target_teams_reduction_max.cpp
 create mode 100644 openmp/libomptarget/test/offloading/parallel_target_teams_reduction_min.cpp

diff --git a/openmp/libomptarget/test/offloading/parallel_target_teams_reduction_max.cpp b/openmp/libomptarget/test/offloading/parallel_target_teams_reduction_max.cpp
new file mode 100644
index 000000000000000..19c05e0bd573c20
--- /dev/null
+++ b/openmp/libomptarget/test/offloading/parallel_target_teams_reduction_max.cpp
@@ -0,0 +1,49 @@
+// RUN: %libomptarget-compilexx-and-run-generic
+// RUN: %libomptarget-compileoptxx-and-run-generic
+
+// FIXME: This is a bug in host offload, this should run fine.
+// UNSUPPORTED: aarch64-unknown-linux-gnu
+// UNSUPPORTED: aarch64-unknown-linux-gnu-LTO
+// UNSUPPORTED: x86_64-pc-linux-gnu
+// UNSUPPORTED: x86_64-pc-linux-gnu-LTO
+
+// This test validates that the OpenMP target reductions to find a maximum work
+// as indended for a few common data types.
+
+#include <algorithm>
+#include <cassert>
+#include <vector>
+
+template <class Tp> void test_max_reduction() {
+  const int length = 1000;
+  const int nmaximas = 8;
+  std::vector<Tp> a(length, (Tp)3);
+  const int step = length / nmaximas;
+  for (int i = 0; i < nmaximas; i++) {
+    a[i * step] += (Tp)1;
+  }
+  for (int i = nmaximas - 1; i >= 0; i--) {
+    int idx = 0;
+    Tp *b = a.data();
+#pragma omp target teams distribute parallel for reduction(max : idx)          \
+    map(always, to : b[0 : length])
+    for (int j = 1; j < length; j++) {
+      if (b[j] > b[j - 1]) {
+        idx = std::max(idx, j);
+      }
+    }
+    assert(idx == i * step &&
+           "#pragma omp target teams distribute parallel for "
+           "reduction(max:<identifier list>) does not work as intended.");
+    a[idx] -= (Tp)1;
+  }
+}
+
+int main() {
+  test_max_reduction<float>();
+  test_max_reduction<double>();
+  test_max_reduction<int>();
+  test_max_reduction<unsigned int>();
+  test_max_reduction<long>();
+  return 0;
+}
diff --git a/openmp/libomptarget/test/offloading/parallel_target_teams_reduction_min.cpp b/openmp/libomptarget/test/offloading/parallel_target_teams_reduction_min.cpp
new file mode 100644
index 000000000000000..e8a8648830b6344
--- /dev/null
+++ b/openmp/libomptarget/test/offloading/parallel_target_teams_reduction_min.cpp
@@ -0,0 +1,49 @@
+// RUN: %libomptarget-compilexx-and-run-generic
+// RUN: %libomptarget-compileoptxx-and-run-generic
+
+// FIXME: This is a bug in host offload, this should run fine.
+// UNSUPPORTED: aarch64-unknown-linux-gnu
+// UNSUPPORTED: aarch64-unknown-linux-gnu-LTO
+// UNSUPPORTED: x86_64-pc-linux-gnu
+// UNSUPPORTED: x86_64-pc-linux-gnu-LTO
+
+// This test validates that the OpenMP target reductions to find a minimum work
+// as indended for a few common data types.
+
+#include <algorithm>
+#include <cassert>
+#include <vector>
+
+template <class Tp> void test_min_reduction() {
+  const int length = 1000;
+  const int nminimas = 8;
+  std::vector<Tp> a(length, (Tp)3);
+  const int step = length / nminimas;
+  for (int i = 0; i < nminimas; i++) {
+    a[i * step] -= (Tp)1;
+  }
+  for (int i = 0; i < nminimas; i++) {
+    int idx = a.size();
+    Tp *b = a.data();
+#pragma omp target teams distribute parallel for reduction(min : idx)          \
+    map(always, to : b[0 : length])
+    for (int j = 0; j < length - 1; j++) {
+      if (b[j] < b[j + 1]) {
+        idx = std::min(idx, j);
+      }
+    }
+    assert(idx == i * step &&
+           "#pragma omp target teams distribute parallel for "
+           "reduction(min:<identifier list>) does not work as intended.");
+    a[idx] += (Tp)1;
+  }
+}
+
+int main() {
+  test_min_reduction<float>();
+  test_min_reduction<double>();
+  test_min_reduction<int>();
+  test_min_reduction<unsigned int>();
+  test_min_reduction<long>();
+  return 0;
+}