[Openmp-commits] [PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

[Job Noorman via Phabricator via Openmp-commits]

jobnoorman added a comment.

In D150549#4380786 <https://reviews.llvm.org/D150549#4380786>, @MaskRay wrote:

> If we are certain this will not be reverted and cause churn, making the header switch in one single patch looks fine to me...

Great. I'm not sure if we can ever be a 100% certain it will not get reverted. To increase our chances, I'll wait a bit before landing this. Does anyone else have thoughts about this patch?

> I have checked that this patch has migrated things that might be neglected: `unittest` directories, openmp,mlir,clang, etc.

Thanks for checking this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150549/new/

https://reviews.llvm.org/D150549