[Openmp-commits] [PATCH] D150882: [OpenMP] remove usage of std::abs in the new loop collapse support code

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added inline comments.


================
Comment at: openmp/runtime/src/kmp_collapse.cpp:31
+// avoid inadevertently using a library based abs
+template <typename T> T __abs(const T _X) {
+  return (_X < 0) ? -_X: _X;
----------------
tianshilei1992 wrote:
> `_X` is not in any format that we try to follow here. Neither LLVM nor `libomp` standard.
Potentially it can be called something like `__kmp_abs`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150882/new/

https://reviews.llvm.org/D150882