[Openmp-commits] [PATCH] D124652: [OpenMP] [OMPT] [amdgpu] [5/8] Implemented device init/fini/load callbacks

[Michael Halkenhäuser via Phabricator via Openmp-commits]

mhalk added inline comments.


================
Comment at: openmp/libomptarget/src/OmptCallback.cpp:91
   // Connect with libomp
   static OmptLibraryConnectorTy LibompConnector("libomp");
   static ompt_start_tool_result_t OmptResult;
----------------
dhruvachak wrote:
> I thought we got rid of these 2 statics.
We wanted to get rid of these statics in `openmp/libomptarget/plugins-nextgen/common/OMPT/OmptCallback.cpp`
Nevertheless good catch, since those were accidentally re-introduced by a rebase.

AFAIK:
We wanted to keep these here, to make sure the `libomp->libomptarget` connection stays alive (esp. w.r.t. the `result`).
But the `libomptarget->plugin` ones should not be static, since we can have multiple plugins.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124652/new/

https://reviews.llvm.org/D124652