[Openmp-commits] [PATCH] D150404: [OpenMP] remove an erroneous assert on the location argument

Vadim Paretsky via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu May 11 15:30:56 PDT 2023

vadikp-intel created this revision.
vadikp-intel added a project: OpenMP.
Herald added subscribers: sunshaoce, guansong, yaxunl.
Herald added a project: All.
vadikp-intel requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: openmp-commits, jplehr, sstefan1.

The 'loc' argument is optional, and some compilers (e.g. MSVC) do no supply it.

  rG LLVM Github Monorepo



Index: openmp/runtime/src/kmp_runtime.cpp
--- openmp/runtime/src/kmp_runtime.cpp
+++ openmp/runtime/src/kmp_runtime.cpp
@@ -8827,7 +8827,6 @@
   int team_size;
-  KMP_DEBUG_ASSERT(loc); // it would be nice to test ( loc != 0 )
   KMP_DEBUG_ASSERT(lck); // it would be nice to test ( lck != 0 )
 #define FAST_REDUCTION_ATOMIC_METHOD_GENERATED                                 \

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150404.521473.patch
Type: text/x-patch
Size: 450 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230511/533c7d71/attachment.bin>

More information about the Openmp-commits mailing list