[Openmp-commits] [PATCH] D124070: [OpenMP] [OMPT] [amdgpu] [4/8] Implemented callback registration in nextgen plugins

[Dhruva Chakrabarti via Phabricator via Openmp-commits]

dhruvachak added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/CMakeLists.txt:85
   MemoryManager
+  OMPT
   PluginInterface
----------------
mhalk wrote:
> tianshilei1992 wrote:
> > A better practice is to link `OMPT` if it is enabled.
> > ```
> > if (OMPT_ENABLED)
> >   target_link_libraries(omptarget.rtl.amdgpu.nextgen PRIVATE OMPT)
> > endif()
> > ```
> Thank you, will be addressed!
For this to work, you probably want to check
if ((OMPT_TARGET_DEFAULT) AND (LIBOMPTARGET_OMPT_SUPPORT))
the same way libomptarget cmake does.

The former needs to be exported to global scope first in libomptarget. The latter should already be available to the plugin.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124070/new/

https://reviews.llvm.org/D124070