[Openmp-commits] [PATCH] D124070: [OpenMP] [OMPT] [amdgpu] [4/8] Implemented callback registration in nextgen plugins

Wed May 3 07:27:21 PDT 2023

mhalk added a comment.

@tianshilei1992 if it's not too much to ask for: Could you please check the updated diff?

If there are no further problems or requests, I would like to re-land this revision.

================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/CMakeLists.txt:85
   MemoryManager
+  OMPT
   PluginInterface
----------------
tianshilei1992 wrote:
> A better practice is to link `OMPT` if it is enabled.
> ```
> if (OMPT_ENABLED)
>   target_link_libraries(omptarget.rtl.amdgpu.nextgen PRIVATE OMPT)
> endif()
> ```
Thank you, will be addressed!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124070/new/

https://reviews.llvm.org/D124070