[Openmp-commits] [PATCH] D124070: [OpenMP] [OMPT] [amdgpu] [4/8] Implemented callback registration in nextgen plugins

Tue May 2 13:31:33 PDT 2023

mhalk added a comment.

In D124070#4313476 <https://reviews.llvm.org/D124070#4313476>, @tianshilei1992 wrote:

> Either only adding the source file when OMPT is enabled, or as suggested by @dhruvachak, guarding the entire file with the `OMPT_SUPPORT`.

Thanks for getting back so fast -- I'll look into the latter approach of moving `#endif // OMPT_SUPPORT` to the bottom of `OmptCallback.cpp` and re-check with different configurations (esp. disabled OMPT).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124070/new/

https://reviews.llvm.org/D124070