[Openmp-commits] [PATCH] D124070: [OpenMP] [OMPT] [amdgpu] [4/8] Implemented callback registration in nextgen plugins

Tue May 2 12:47:14 PDT 2023

mhalk added a comment.

@tianshilei1992 Thank you very much!
Sorry that I was unavailable for the last hour, just got at the PC.

I'll have a look at the errors and see how I can reproduce them, but I'm honestly surprised (since I built this on multiple systems without problems).

> Another thing is, I disabled OMPT on my side, and OmptCallback.cpp is added to the source file without any guard. That has to be fixed as well.

Just to make sure, you're talking about a guard that e.g. prevents `OmptCallback.cpp` to produce an object file when OMPT is not enabled (e.g. in the CMakeLists), correct?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124070/new/

https://reviews.llvm.org/D124070