[Openmp-commits] [PATCH] D124070: [OpenMP] [OMPT] [amdgpu] [4/8] Implemented callback registration in nextgen plugins

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

I encountered a compile error when building openmp.

  [4/143] Building CXX object libomptarget/src/CMakeFiles/omptarget.dir/OmptCallback.cpp.o
  FAILED: libomptarget/src/CMakeFiles/omptarget.dir/OmptCallback.cpp.o
  /gpfs/jlse-fs0/users/ac.shilei.tian/build/llvm/release/bin/clang++ -DGTEST_HAS_RTTI=0 -DOMPTARGET_DEBUG -I/home/ac.shilei.tian/Documents/vscode/llvm-project/llvm/include -I/gpfs/jlse-fs0/users/ac.shilei.tian/build/llvm/release/include -I/home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/include -Wall -Wcast-qual -Wformat-pedantic -Wimplicit-fallthrough -Wsign-compare -Wno-enum-constexpr-conversion -Wno-extra -Wno-pedantic -std=c++17 -g -fPIC  -fno-exceptions -funwind-tables -fno-rtti -MD -MT libomptarget/src/CMakeFiles/omptarget.dir/OmptCallback.cpp.o -MF libomptarget/src/CMakeFiles/omptarget.dir/OmptCallback.cpp.o.d -o libomptarget/src/CMakeFiles/omptarget.dir/OmptCallback.cpp.o -c /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/src/OmptCallback.cpp
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/src/OmptCallback.cpp:124:32: error: unknown type name 'ompt_start_tool_result_t'
  void ompt_libomptarget_connect(ompt_start_tool_result_t *result) {
                                 ^
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/src/OmptCallback.cpp:125:3: error: use of undeclared identifier 'DP'
    DP("OMPT: Enter ompt_libomptarget_connect\n");
    ^
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/src/OmptCallback.cpp:126:7: error: use of undeclared identifier 'OmptEnabled'
    if (OmptEnabled && result) {
        ^
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/src/OmptCallback.cpp:128:5: error: use of undeclared identifier 'LibraryFinalizer'
      LibraryFinalizer.registerRtl(result->finalize);
      ^
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/src/OmptCallback.cpp:132:24: error: use of undeclared identifier 'OmptDeviceCallbacksTy'
      result->initialize(OmptDeviceCallbacksTy::doLookup,
                         ^
  /home/ac.shilei.tian/Documents/vscode/llvm-project/openmp/libomptarget/src/OmptCallback.cpp:135:3: error: use of undeclared identifier 'DP'
    DP("OMPT: Leave ompt_libomptarget_connect\n");
    ^
  6 errors generated.

Do we want to revert it or a quick fix will be landed soon?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124070/new/

https://reviews.llvm.org/D124070