[Openmp-commits] [PATCH] D146642: [OpenMP] Implement task record and replay mechanism

[Jose Manuel Monsalve Diaz via Phabricator via Openmp-commits]

josemonsalve2 added a comment.

In D146642#4229067 <https://reviews.llvm.org/D146642#4229067>, @tianshilei1992 wrote:

> In D146642#4229048 <https://reviews.llvm.org/D146642#4229048>, @josemonsalve2 wrote:
>
>> In D146642#4228996 <https://reviews.llvm.org/D146642#4228996>, @tianshilei1992 wrote:
>>
>>> I think it's better to guard the entire related code with macro.
>>
>> What do you mean by this Shilei? To disable this feature?
>
> Like a opt-in feature.

Why do you think so? What's the harm of leaving it enable as this is just an API function? Are you saying this to save space in the structs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146642/new/

https://reviews.llvm.org/D146642