[Openmp-commits] [PATCH] D146642: [OpenMP] Implement task record and replay mechanism

Shilei Tian via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Mar 28 16:36:06 PDT 2023


tianshilei1992 added a comment.

I think it's better to guard the entire related code with macro.



================
Comment at: openmp/runtime/src/kmp_global.cpp:569
+// end of file //
\ No newline at end of file

----------------
add an extra line to the end


================
Comment at: openmp/runtime/src/kmp_tasking.cpp:19
 #include "kmp_taskdeps.h"
-
 #if OMPT_SUPPORT
----------------
unrelated change


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146642/new/

https://reviews.llvm.org/D146642



More information about the Openmp-commits mailing list