[Openmp-commits] [PATCH] D146894: [OpenMP] Fix an OpenMP Windows build problem

Mon Mar 27 13:41:39 PDT 2023

mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! This is indeed the neatest solution so far!

================
Comment at: openmp/runtime/src/CMakeLists.txt:304
         STATIC_LIBRARY_OPTIONS "${CMAKE_LINK_DEF_FILE_FLAG}${CMAKE_CURRENT_BINARY_DIR}/${LIBOMPIMP_GENERATED_DEF_FILE}")
     add_dependencies(${LIBOMP_IMP_LIB_TARGET} omp libompimp-needed-def-file)
   endif()
----------------
Can't we get rid of the `omp` dependency here at this point too, since there's no technical need to build it after the main library has been built?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146894/new/

https://reviews.llvm.org/D146894