[Openmp-commits] [PATCH] D146925: [OpenMP] Fix building the second import library when built in the main llvm build root

[Martin Storsjö via Phabricator via Openmp-commits]

mstorsjo added a comment.

In D146925#4225492 <https://reviews.llvm.org/D146925#4225492>, @vadikp-intel wrote:

> I will be good with this solution, but I think there could be a simpler one in the end.  While CMAKE does wants to see a source, that does not have to be a `cpp` (which is what's causing this need to unnecessarily feed the first step's library to satisfy `lib`'s attempt at `def` symbols resolution). There are other source types (e.g., a. `txt`) which will satisfy the source presence requirement but which CMAKE will filter out from the librarian generating the right command line for it.

Oh, nice, if that works, that's probably even better!

I did try to convert the import library generation to a cmake custom target, and I got it working, but I'm not entirely convinced that it's any better than what we have right now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146925/new/

https://reviews.llvm.org/D146925