[Openmp-commits] [PATCH] D146849: [OpenMP][libomptarget] Active and blocking HSA wait states

[Jan-Patrick Lehr via Phabricator via Openmp-commits]

jplehr added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:501
+  AMDGPUSignalTy(uint64_t MicrosToWait)
+      : Signal({0}), UseCount(), MicrosToWait(MicrosToWait) {}
 
----------------
jdoerfert wrote:
> I would think we want a Env var and all Signal behave the same, so no argument here, wdyt?
In AOMP, we actually use different values for data transfers and kernel launches.
I don't think we need this for now, but we should do some experimentation to see what works best with NextGen plugin.
So, I'll change that and make it an EnvVar.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1964
+      /* Example use for microseconds to wait */
+      AMDGPUSignalTy Signal(300000);
       if (auto Err = Signal.init())
----------------
ye-luo wrote:
> Not getting what you mean by "Example use".
> Could you document the magic number 300000?
Example use is copied from AOMP.
For data transfers we use this timeout (for kernels we use a different one). As said above, probably we should remove for now, and do some experimentation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146849/new/

https://reviews.llvm.org/D146849