[Openmp-commits] [PATCH] D144419: Improvements to the OpenMP Windows build

[Vadim Paretsky via Phabricator via Openmp-commits]

vadikp-intel reopened this revision.
vadikp-intel added a comment.
This revision is now accepted and ready to land.

The source of problem is the attempt to re-use the results of the first build in order to avoid rebuilding the sources the second time to just re-generate the import library. This is being done by feeding the main build's import library as a source to the second one (@301) with CMAKE ending up assuming the library is located where the sources are, hence the reference to `projects/openmp/runtime/src/libomp.dll.lib` instead of what should be `lib/libomp.dll.lib` in the LLVM based build. At this point, I do not see a good way to just repoint CMAKE to the first build's drop location, and reusing its library would likely require doing a custom target. I think a cleaner and better solution is to simply rebuild the second one from sources (it's a small build). I'll submit a patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144419/new/

https://reviews.llvm.org/D144419