[Openmp-commits] [PATCH] D127365: [OpenMP] [OMPT] [6/8] Added callback support for target data operations, target submit, and target regions.

[Michael Halkenhäuser via Phabricator via Openmp-commits]

mhalk added inline comments.


================
Comment at: openmp/libomptarget/src/OmptCallback.cpp:53
+/// Used to create a new correlation id
+static uint64_t id_create() { return unique_id_ticket.fetch_add(1); }
+
----------------
jplehr wrote:
> These functions should probably be updated to follow the LLVM naming convention, e.g., `createId`. Idk if this should be done right now, or in an NFC after the OMPT support has landed.
@NFC I was asking myself the same question.
But of course I could incorporate such NFCs in this set / stack of patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127365/new/

https://reviews.llvm.org/D127365