[Openmp-commits] [PATCH] D137607: Add interop support for OpenMP AMD GPU plugin

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, assuming the test pass. Two minor nits below.



================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:1864
+         "device_id is invalid");
+  assert(&(InteropPtr)->device_info && "device_info_ptr is nullptr");
+
----------------
This check (with the `&`) doesn't make much sense, did you mean w/o `&`?


================
Comment at: openmp/libomptarget/plugins/cuda/src/rtl.cpp:1874
+    DeviceRTL.initDeviceInfo(DeviceId, &(InteropPtr)->device_info,
+                             &(InteropPtr)->err_str);
+  } else {
----------------
Why the parenthesis around InteropPtr and not the entire expression?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137607/new/

https://reviews.llvm.org/D137607