[Openmp-commits] [PATCH] D145924: [OpenMP][libomptarget][AMDGPU] Update print launch info

Johannes Doerfert via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Mar 14 16:40:36 PDT 2023


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, one more suggestion



================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:2646
+       "Usage: %uB SGPR Count: %u VGPR Count: %u "
+       "SGPR Spill Count: %u VGPR Spill Count: %u Tripcount: %lu\n",
+       ArgNum, NumGroups, ThreadsPerGroup, MaxFlatWorkgroupSize,
----------------
I would try to shorten this, like `#` for count, maybe SPGR/VPGR and then <N>/<M>, etc. But this is already better than what we had.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145924/new/

https://reviews.llvm.org/D145924



More information about the Openmp-commits mailing list