[Openmp-commits] [PATCH] D144975: [OpenMP][libomptarget][NFC] Add documentation regarding NextGen plugins

Mon Mar 13 06:11:16 PDT 2023

jplehr added inline comments.
Herald added a subscriber: sunshaoce.

================
Comment at: openmp/docs/design/Runtimes.rst:1244
+streams. More HSA signals will be created dynamically throughout the execution
+if needed. The default value is ``64``.
+
----------------
kevinsala wrote:
> jdoerfert wrote:
> > Is this separate from the other SIGNALS env var on purpose? We can discuss this in our meeting.
> Which SIGNALS envars are you referring to?
> 
> There are the other two `LIBOMPTARGET_NUM_INITIAL_STREAMS` and `LIBOMPTARGET_NUM_INITIAL_EVENTS` envars. But these two are different since these two apply to all plugins and `LIBOMPTARGET_AMDGPU_NUM_INITIAL_HSA_SIGNALS` only applies to AMDGPU.
Is there a specific reason why more `HSA_SIGNALS` are created initially than `EVENTS`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144975/new/

https://reviews.llvm.org/D144975