[Openmp-commits] [PATCH] D145513: [Libomptarget] Update handling of architectures for DeviceRTL

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/DeviceRTL/CMakeLists.txt:68
+
+set(LIBOMPTARGET_DEVICE_ARCHITECTURES ${all_gpu_architectures} CACHE STRING
+    "List of device architectures to be used to compile the OpenMP DeviceRTL.")
----------------
ye-luo wrote:
> Prefer default all instead of the full list.
> When doing an incremental build and having new arch being listed. `all` continue to build everything but cached list doesn't 
Good point


================
Comment at: openmp/libomptarget/DeviceRTL/CMakeLists.txt:74
+elseif(LIBOMPTARGET_DEVICE_ARCHITECTURES STREQUAL "auto")
+  if (NOT LIBOMPTARGET_NVPTX_ARCH AND NOT LIBOMPTARGET_AMDGPU_ARCH)
+    libomptarget_error_say(
----------------
ye-luo wrote:
> Are both tool always built together?
Yes, they are always built by `clang`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145513/new/

https://reviews.llvm.org/D145513