[Openmp-commits] [PATCH] D144975: [OpenMP][libomptarget][NFC] Add documentation regarding NextGen plugins

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

Nice! Thanks a lot!



================
Comment at: openmp/docs/design/Runtimes.rst:1209
+used for inserting kernel packets to launching kernel executions. A high number
+of HSA queues may degrade the performance. The default value is ``4``.
+
----------------
Nit: Format the paragraph to 80 columns.


================
Comment at: openmp/docs/design/Runtimes.rst:1244
+streams. More HSA signals will be created dynamically throughout the execution
+if needed. The default value is ``64``.
+
----------------
Is this separate from the other SIGNALS env var on purpose? We can discuss this in our meeting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144975/new/

https://reviews.llvm.org/D144975