[Openmp-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

Fri Jun 9 13:43:19 PDT 2023

MaskRay added a comment.

In D141907#4094748 <https://reviews.llvm.org/D141907#4094748>, @MaskRay wrote:

> [...]
> edeaf16f2c2f02d6e43312d48d26d354d87913f3 (2011) added the CMake variable `CLANG_RESOURCE_DIR` but did not explain why. 
> In the long term, the CMake variable `CLANG_RESOURCE_DIR` probably should be removed.

My feeling stays the same. In the long term, we should try removing the CMake variable `CLANG_RESOURCE_DIR`.
Customizing the variable in a special way will make some `clang/test/Driver` tests fail, I don't know it's healthy for contributors to be aware of this yet-another configure variable for `clang/test/Driver` tests. The `CLANG_RESOURCE_DIR` users should be served by specifying `-resource-dir=` in a configuration file (https://clang.llvm.org/docs/UsersManual.html#configuration-files)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141907/new/

https://reviews.llvm.org/D141907