[Openmp-commits] [PATCH] D156387: [OpenMP][Docs] Added offloading command line reference to OpenMP FAQ

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/docs/CommandLineArgumentReference.rst:54
+may specify ``-fopenmp-targets=amdgcn-amd-amdhsa,nvptx64``. This option is 
+often optional when :ref:`offload_arch` is provided.
+
----------------
Maybe mention CPU offloading here, like with `-fopenmp-targets=x86_64-pc-linux-gnu`.


================
Comment at: openmp/docs/CommandLineArgumentReference.rst:65-66
+| It is also possible to specify :ref:`fopenmp-targets` without specifying 
+  ``--offload-arch``. In that case, the executables ``bin/amdgpu-arch`` or
+  ``bin/nvptx-arch`` will be executed as part of the compiler driver to 
+  detect the device arhitecture automatically.
----------------
Drop the `bin`. Also we infer with `--offload-arch=native` as well.


================
Comment at: openmp/docs/CommandLineArgumentReference.rst:184
+include paths.
\ No newline at end of file

----------------
Should be fixed


================
Comment at: openmp/docs/SupportAndFAQ.rst:84
 
-- `LIBOMPTARGET_NVPTX_COMPUTE_CAPABILITIES=YY` where `YY` is the numeric compute capacity of your GPU, e.g., 75.
+- ``LIBOMPTARGET_NVPTX_COMPUTE_CAPABILITIES=YY`` where ``YY`` is the numeric compute capability of your GPU, e.g., 75.
 
----------------
Wait I think this is totally wrong, I removed that in 17. It's `LIBOMPTARGET_DEVICE_ARCHITECTURES=sm_70,gfx1030` now for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156387/new/

https://reviews.llvm.org/D156387