[Openmp-commits] [PATCH] D156387: [OpenMP][Docs] Added offloading command line reference to OpenMP FAQ

[Johannes Doerfert via Phabricator via Openmp-commits]

jdoerfert added inline comments.


================
Comment at: openmp/docs/SupportAndFAQ.rst:518-521
+
+``-fno-openmp-target-debug``
+""""""""""""""""""""""""""""
+Disable debugging in the device RTL.
----------------
Remove the negative option, describe the bits (or link to the docs) that you can set and that you need the env var too.


================
Comment at: openmp/docs/SupportAndFAQ.rst:525
+"""""""""""""""""""""""
+Emit code that can be Just-in-Time (JIT) compiled for OpenMP offloading.
+
----------------
Not can be, *is*. So: Embed LLVM-IR for the device code in the object files rather than binary code for the respective target. At runtime the LLVM-IR is optimized again and compiled for the target device. Link to the JIT options, and mention this is good for debugging.


================
Comment at: openmp/docs/SupportAndFAQ.rst:533-535
+``--no-offload-new-driver``
+"""""""""""""""""""""""""""
+Do not use the new driver for offloading compilation.
----------------
jdoerfert wrote:
> @jhuber6, am I correct in assuming there is no "old" driver for OpenMP, and we should tell people this is only for HIP/CUDA? (even there it seems silly, this is probably not of use right now)
So, let's just talk about the positive option right now.


================
Comment at: openmp/docs/SupportAndFAQ.rst:541
+experimentally linked with CUDA and HIP files. The new offloading linker must be
+used when linking with CUDA or HIP files.
+
----------------
This is default for OpenMP, right (@jhuber6)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156387/new/

https://reviews.llvm.org/D156387