[Openmp-commits] [PATCH] D156387: [OpenMP][Docs] Added offloading command line reference to OpenMP FAQ

[Jan-Patrick Lehr via Phabricator via Openmp-commits]

jplehr added a comment.

Thanks for putting this together!

I had some minor comments.



================
Comment at: openmp/docs/SupportAndFAQ.rst:84
 
-- `LIBOMPTARGET_NVPTX_COMPUTE_CAPABILITIES=YY` where `YY` is the numeric compute capacity of your GPU, e.g., 75.
+- ``LIBOMPTARGET_NVPTX_COMPUTE_CAPABILITIES=YY`` where ``YY`` is the numeric compute capacity of your GPU, e.g., 75.
 
----------------
I think this should be  `capability`


================
Comment at: openmp/docs/SupportAndFAQ.rst:477-478
+""""""""""""""""""""""""""""""""""""""""""""""""""""
+Compile the target regions for the host only. All target regions will be 
+compiled for both host and device if not specified.
+
----------------
Flip the flags or the sentences, so that the flags and their meaning are in the same order.


================
Comment at: openmp/docs/SupportAndFAQ.rst:482
+"""""""""""""""""""""""""
+Pass an argument to the offloading toolchain, for instance 
+``-Xopenmp-target -march=sm_80``.
----------------
have in this and the next paragraph also "Pass an argument ``<arg>`` ... " as it is written further down.


================
Comment at: openmp/docs/SupportAndFAQ.rst:506
+"""""""""""""""""
+Enable ``full`` link time optimization on the device. This option is equivalent to 
+``-foffload-lto=full``. 
----------------
I assume LTO is not actually running on the device, so maybe rephrase to

... optimization for device code.


================
Comment at: openmp/docs/SupportAndFAQ.rst:527
+
+``--offload-new-driver``
+""""""""""""""""""""""""
----------------
Should be indicated which one is the default, i.e., old or new?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156387/new/

https://reviews.llvm.org/D156387