[Openmp-commits] [PATCH] D127367: [OpenMP] [OMPT] [7/8] Invoke tool-supplied callbacks before and after target launch and data transfer operations

Michael Halkenhäuser via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 25 05:19:56 PDT 2023


mhalk added inline comments.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:1684
+    int32_t NumTeams = KernelArgs.NumTeams[0];
+    // No need to guard this with OMPT_IF_BUILT
+    InterfaceRAII TargetSubmitRAII(
----------------
jplehr wrote:
> nit: Why?
Because we're already checking via `#ifdef OMPT_SUPPORT`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127367/new/

https://reviews.llvm.org/D127367



More information about the Openmp-commits mailing list