[Openmp-commits] [PATCH] D155903: [Libomptarget] Configure the RPC port count from the plugin

Thu Jul 20 20:21:30 PDT 2023

jhuber6 added inline comments.

================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:2471
+  /// The total number of concurrent work items that can be running on the GPU.
+  uint64_t HardwareParallelism;
+
----------------
jdoerfert wrote:
> In a follow up, can you please expose this via ompx_get_hardware_num_processing_elements(int device) (or whatever the non device version is spelled)?
Yeah I'm not sure how to calculate this on CUDA unfortunately.

================
Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/RPC.cpp:64
+      std::min(Device.requestedRPCPortCount(), RPC_MAXIMUM_PORT_COUNT);
+  if (rpc_status_t Err = rpc_server_init(DeviceId, NumPorts,
                                          Device.getWarpSize(), Alloc, &Device))
----------------
JonChesterfield wrote:
> This should probably be a hard error if the plugin wants more ports than it can have, especially on platforms where that implies deadlock risk
Was putting that off considering that the limit is currently like 64, which is far below the like 2000 that most platforms will want.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155903/new/

https://reviews.llvm.org/D155903