[Openmp-commits] [PATCH] D127367: [OpenMP] [OMPT] [7/8] Invoke tool-supplied callbacks before and after target launch and data transfer operations

[Michael Halkenhäuser via Phabricator via Openmp-commits]

mhalk added inline comments.


================
Comment at: openmp/libomptarget/src/OmptCallback.cpp:45
+/// Initialization status
+bool llvm::omp::target::ompt::Initialized = false;
+
----------------
Some sort of init flag will be needed.
Originally thought the timeline would allow to go with a separate patch.
See D155186


================
Comment at: openmp/libomptarget/src/device.cpp:48
+  void beginOp() {
+    // if (!OmptEnabled) return;
+    CodePtr = OMPT_GET_RETURN_ADDRESS(0);
----------------
Oversight: Six occurrences -- will be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127367/new/

https://reviews.llvm.org/D127367