[Openmp-commits] [PATCH] D155621: [OpenMP][libomptarget] Improve plugin resource managers

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1189
     // Consume another stream slot and compute dependencies.
-    std::tie(Curr, InputSignal) = consume(OutputSignal2);
+    std::tie(Curr, InputSignal) = consume(OutputSignals[1]);
     assert(InputSignal && "Invalid input signal");
----------------
Don't need `std::tie` anymore, C++17 structured bindings should work.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1219-1226
+    if (auto Err = SignalManager.getResource(OutputSignals[0]))
+      return Err;
+    if (auto Err = SignalManager.getResource(OutputSignals[1]))
+      return Err;
+    OutputSignals[0]->reset();
+    OutputSignals[1]->reset();
+    OutputSignals[0]->increaseUseCount();
----------------
Any reason we can't do this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155621/new/

https://reviews.llvm.org/D155621